feat: more specific times recurrence

[orimdominic]

Add two methods for specific recurrence

1. specific recurrence for day: everyDayAtHourAndMinute(hour, minute)
2. specific recurrence for month: everyMonthAt(day, hour, minute)

[omarkhairy21]

Add two methods for specific recurrence

1. specific recurrence for day: everyDayAtHourAndMinute(hour, minute)
2. specific recurrence for month: everyMonthAt(day, hour, minute)

Thanks for contributing again, You may follow up the same convention of fromDay().toDayAt(day, hour) but i did not notice it would not be clear when hour and minutes be as arguments at the same function so it may make the developer confused for moments until figuring out which argument is the hour.

I do suggest to change to be like

1. For day everyDay().atHour(hour).atMinute(minute)
2. For Month everyMonth().atDay(day).atHour(hour).atMinute(minute)

I would like to hear your thoughts on that

[orimdominic]

Thank you for the feedback.

Your suggestion is how I wanted to implement it because I noticed
from the style in the codebase that all functions have an arity of 1. I wrote
it this way because I was considering that users may not want to call all functions
to completion.

For example, a user may want to do only everyDay().atHour(hour) from
everyDay().atHour(hour).atMinute(minute) or only everyMonth().atDay(day) from
everyMonth().atDay(day).atHour(hour).atMinute(minute); and I did not know
if you will want that allowed.

I will make a PR following your suggested convention and I plan to implement it by
doing something similar to

function everyDay() {
  let expression = "min hour * * *";
  return {
    toString() { // or toExpression
      return "0 0 * * *";
    },
    atHour(_hour) {
      expression = expression.replace("hour", _hour);

      return {
        toString() { // or toExpression
          return expression.replace("min", "0");
        },
        atMinute(_minute) {
          return expression.replace("min", _minute);
        },
      };
    },
  };
}
console.log(everyDay().toString()); // 0 0 * * *
console.log(everyDay().atHour(2).toString()); // 0 2 * * * 
console.log(everyDay().atHour(2).atMinute(30)); // 30 2 * * *

We can also make it strict by making sure that all functions are complete executed,
and then remove the toString function returned by the atHour function.
The toString function returned by everyDay has to remain because there already
exists an everyDay function that returns 0 0 * * *.
A suggestion to bypass this is to call the current function that will be written for this
daily().atHour().atMinute() and the other monthly().onDay().atHour()...

What are your thoughts?

[orimdominic]

@omarkhairy21 just mentioning you once again in case you missed my latest comment

[omarkhairy21]

Thanks for mentioning and reminder i apologize i was very busy last week i pretty much agree with you except use toString we can replace it with get
so it would be like that

console.log(everyDay().atHour(2).get()); // 0 2 * * * 

[orimdominic]

Thank you for the feedback @omarkhairy21
I've updated the PR.
Kindly check it out when you can.

[omarkhairy21]

Thanks, Orim Great work! I did add a small fix for months starting from 0 to 12 (13 months lol!..my mistake) but that standard was 1-12.

I will create a new issue to improve the readability of the test description. if you can work on that.

[omarkhairy21]

Geat @orimdominic thanks.