Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V05 dev2 #36

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

V05 dev2 #36

wants to merge 28 commits into from

Conversation

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for ome-ngff-validator ready!

Name Link
🔨 Latest commit 1d55e98
🔍 Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/66f2ccb0ad494700080ee7ac
😎 Deploy Preview https://deploy-preview-36--ome-ngff-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshmoore
Copy link
Member

@will-moore @manzt: I've also hard-coded the URL for hms-dbmi/vizarr#172 here as well 👍

@joshmoore
Copy link
Member

When using ome_zarr view idr0001-2551.zarr

image

When using .../idr0001-2551.zarr $ http-server --cors

image

@joshmoore
Copy link
Member

👍 from my side on the additional column:

image

@will-moore
Copy link
Member Author

@joshmoore Not exactly sure what you're doing there....

$ ls plates/
2783928.zarr	4403.zarr	51.zarr
$ http-server --cors

https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=http://127.0.0.1:8080/plates/4403.zarr
Looks good.

Also e.g.

$ $ http-server plates --cors

Works at https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=http://127.0.0.1:8080/4403.zarr
etc.

@joshmoore
Copy link
Member

Sorry, I just wanted to get a screenshot in place. No complaints 😄

@joshmoore
Copy link
Member

Initial RO-Crate validation! 🎉

image

cc: @sherwoodf

@will-moore
Copy link
Member Author

@sherwoodf - I noticed you had key licence at https://github.com/ome/ome2024-ngff-challenge/blob/53cdf2b73dec2a8341998b7a114a16dea3e5424f/dev3/zarr-crate/example_usage/example_ro_crate/ro-crate-metadata.json#L26C7-L26C65 and Josh had the same in the sample above. But we think this should be license as at https://schema.org/license. So the validator is checking for license.

NB: for name, description and license I'm just looking for the first "@graph" item that has those attributes, which is very simplistic. Any suggestions on improvements to this validation logic would be appreciated!

@sherwoodf
Copy link

@will-moore On license vs licence - you're definitely correct it should be licen_s_e

I think looking for objects with those fields works for the basic ro-crates that we're expecting to get.

If you wanted to invest in something longer term right now (which might be over the top), I would recommend using some sort of ro-crate/linked data tooling instead because the flattened data structure isn't wonderful for parsing, and we can probably update rules we go.

I've only used the python one, but there is a javascript package that might work with svelte: https://www.npmjs.com/package/ro-crate - it mentions an 'in development' validation promises.

We could write shacl shapes and run on the rdf graph that gets produced (https://github.com/zazuko/rdf-validate-shacl) - again, probably over engineering a solution for what we need right now. I could write us some shapes if we wanted to go down that route (if you're not familiar with them they're essentially schema descriptions for validating rdf graphs)

@sherwoodf
Copy link

@will-moore ignore the bit about shacl - i've just remembered that we don't have terms for the fbbi_id yet so it gets dropped from the RDF graph.

@joshmoore
Copy link
Member

@will-moore
Copy link
Member Author

@joshmoore @normanrz That non-sharded image is fixed now: https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://data-humerus.webknossos.org/data/zarr3_experimental/scalable_minds/l4_sample/color
But I don't see any chunks being loaded. I'm getting 404s when I try to load any chunk, and I'm not seeing anything in vizarr either. It is mostly a sparse image or is something broken?

Screenshot 2024-08-22 at 08 51 14

@normanrz
Copy link

The dataset is sparse indeed. Data starts at 3072,3072,512. Unfortunately, OME-Zarr or Zarr don't have metadata for storing data offsets like this.
Screenshot 2024-08-22 at 11 34 54

https://webknossos.org/links/EIyfC3zTaCNnB8Df

@will-moore
Copy link
Member Author

That last commit attempts to look-up Organism and Imaging method. E.g.
https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/share/ome2024-ngff-challenge/0.0.5/idr0010/76-45.zarr

Screenshot 2024-08-22 at 12 35 35

@joshmoore
Copy link
Member

Only quick thought is if we can have two more levels of "not there":

  • ✅ there
  • ❌ missing (license)
  • ✖️ missing (organism / modality)
  • [ ] or just omit (name / description)



<div class="rocrate">
<h1>Ro-crate metadata</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>Ro-crate metadata</h1>
<h1>RO-Crate metadata</h1>

could potentially have a info (I) with a link to what RO-Crate is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants