pip installable #1
Conversation
jburel
force-pushed
the
setup-withtest
branch
from
f3d687d
to
3e3a6cd
Compare
src/omero/plugins/render.py
Outdated
| self._copy_single(gateway, src_img, target, skipthumbs) | ||
| # finally: | ||
| # if close: | ||
| # src_img._closeRE() |
There was a problem hiding this comment.
Can remove commented-out lines and the "close" argument from def _copy()
There was a problem hiding this comment.
The argument is not used but as soon as the method is available in omero cf ome/openmicroscopy#5545
it will.
It makes more sense to keep it even if it is not used for now
src/omero/plugins/render.py
Outdated
| return d | ||
|
|
||
| def close(self): | ||
| self.image._closeRE() | ||
| print 'not yet implemented' | ||
| # self.image._closeRE() |
There was a problem hiding this comment.
Should this be implemented?
e.g.
if self.image._re is not None:
try:
self.image._re.close()
except:
# log...
There was a problem hiding this comment.
I could to that in the meantime
until the method is available in the main line
|
Travis log looks good... and |
Major changes: * All .travis.yml commands now live in test-omero * All actions take place in docker rather than locally * All classes live in omero_cli_render to prevent shadowing The next step here will be to remove the copied cli.py module in favor of pulling the clisplit image.
|
Running build matches this commit: ome/omero-test-infra@76cdeb0 |
|
🎉 Green with the re-usable infrastructure. |
|
great |
| from setuptools.command.test import test as test_command | ||
|
|
||
|
|
||
| class PyTest(test_command): |
There was a problem hiding this comment.
I'll look into migrating this to a library for re-use.
There was a problem hiding this comment.
|
Green again. The updated |
|
Delaying the removal of |
In this PR:
cli.py)Few commits have not been ported to openmicroscopy/develop so some methods cannot be used yet.
It is not currently possible to run the CLI tests outside openmicroscopy(https://github.com/openmicroscopy/openmicroscopy) repo without copying
cli.pyto this repo.When
cli.pyis available fromtestlib, the file should be removed from this repository and the test adjusted.2 PRs will be opened against openmicroscopy/develop:
cli.pyTest cli openmicroscopy#5548To Test:
manually
python setup.py sdist installbin/omero render -hfor the list of supported commandsAutomatically
Similar strategy could be used on other plugin repositories to run the integration tests when we have migrated
cli.pycc @joshmoore @manics