-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway methods #5545
Gateway methods #5545
Conversation
A new "tracked service" internal API has been added. All calls to `_create_func` in `ProxyObjectWrapper` now registers the string representation of the created service as well as the current call stack to the owning `BlitzGateway` instance. If on deletion, services are left open, then an ERROR message including the call stack will be printed.
Tests are passing and make sense. Given that really all services are registered via the |
All services are registered, what is important is to make sure that they are all closed. |
A bit concerned by how invasive some of the changes are (i.e. it will be easy to forget to follow the patterns when writing new tests). 2 questions:
|
This will require discussion since I do not know what was the initial plan on the metadata branch |
This has been in for some time. Merging to take a look at the omero-cli-render repo. Note: created https://trello.com/c/Qc6QEQS0/40-remove-need-for-imgclosere to come back to the changes here and try to remove the invasiveness. |
What this PR does
set_active_channels
and deprecatesetActiveChannels
Related reading
see ome/omero-cli-render#1
To test
cc @joshmoore