Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUPPORT.md & link from README #255

Merged
merged 4 commits into from
Jan 11, 2018
Merged

Add SUPPORT.md & link from README #255

merged 4 commits into from
Jan 11, 2018

Conversation

hflynn
Copy link
Contributor

@hflynn hflynn commented Dec 6, 2017

@hflynn
Copy link
Contributor Author

hflynn commented Dec 6, 2017

Link is working now so Travis failure is unrelated to this PR

@sbesson
Copy link
Member

sbesson commented Dec 6, 2017

Travis errors seems to be E722 and E741. But I see a lot of open PRs are already suffering from these. For the upcoming 3.2.0 release, we'll want to get this fixed prior to integrating the ongoing work. @will-moore @jburel is there already an open PR or staging branch containing the necessary fixes?

@will-moore
Copy link
Member

#251 contains flake8 fixes

@sbesson
Copy link
Member

sbesson commented Dec 6, 2017

Thanks. #251 is currently conflicting and needs some review as far as I can tell so I would not tie the changes to this feature PR. Either the flake fixes need to be open as a standalone PR or we could to cherry-pick the changes here and fix master.
Main concern about 14b7807 is that I am unclear about the dropping of the try/except blocks (14b7807#diff-0a76704154b08eff719dbe89fa944468L233 and 14b7807#diff-0a76704154b08eff719dbe89fa944468L378) and the dropped .getValue() (14b7807#diff-0a76704154b08eff719dbe89fa944468R236) - do these require testing?

@jburel
Copy link
Member

jburel commented Dec 6, 2017

Being more explicit in the try/except should have been done from the start in my opinion
I would not have expected the getValue to be removed

@jburel jburel added this to the 3.2.0 milestone Jan 4, 2018
README.rst Outdated
@@ -12,6 +12,7 @@ An OMERO.web app for creating figures from images in OMERO.

For full details see http://figure.openmicroscopy.org

Also see [SUPPORT.md](./SUPPORT.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will simply it and only indicate

For full details see [SUPPORT.md](./SUPPORT.md)

@hflynn
Copy link
Contributor Author

hflynn commented Jan 11, 2018

@jburel edit pushed

@jburel
Copy link
Member

jburel commented Jan 11, 2018

Thanks @hflynn merging

@jburel jburel merged commit d1492d4 into ome:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants