Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scc to work with repos where issues are disabled #131

Closed
sbesson opened this issue Dec 4, 2013 · 0 comments · Fixed by #176
Closed

Fix scc to work with repos where issues are disabled #131

sbesson opened this issue Dec 4, 2013 · 0 comments · Fixed by #176

Comments

@sbesson
Copy link
Member

sbesson commented Dec 4, 2013

The current implementation of scc, especially the PullRequest object assumes issues are activated by a repository and that each PR has a corresponding issue. By default, issues are disabled for e.g. fork repositories.
The code should be modified to allow commands to work with repos without issues, for instance we could catch the following exception:

GithubException: 410 {u'documentation_url': u'http://developer.github.com/v3/issues/', u'message': u'Issues are disabled for this repo'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant