Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCC assumes a PR's repo name is the same as upstream #192

Closed
manics opened this issue Nov 20, 2014 · 1 comment · Fixed by #193
Closed

SCC assumes a PR's repo name is the same as upstream #192

manics opened this issue Nov 20, 2014 · 1 comment · Fixed by #193

Comments

@manics
Copy link
Member

manics commented Nov 20, 2014

E.g. ome/ome-docker#1

upstream https://github.com/ome/docker/
PR branch: https://github.com/manics/omedocker/tree/remove_omedocker

2014-11-20 11:43:58,185 [     scc.git] DEBUG ## Unique users: set([u'manics'])
2014-11-20 11:43:58,185 [     scc.git] DEBUG Calling 'git remote add merge_manics git://github.com/manics/docker.git'
2014-11-20 11:43:58,188 [     scc.git] DEBUG Fetching remote merge_manics...
2014-11-20 11:43:58,189 [     scc.git] DEBUG Calling 'git fetch merge_manics'

2014-11-20 11:43:58,375 [     scc.git] DEBUG fatal: remote error: 
2014-11-20 11:43:58,375 [     scc.git] DEBUG   Repository not found.
2014-11-20 11:43:58,375 [   scc.merge] DEBUG Cleaning remote branches created for merging
2014-11-20 11:43:58,375 [     scc.git] DEBUG Calling 'git remote'
2014-11-20 11:43:58,378 [     scc.git] DEBUG Calling 'git remote rm merge_manics'
@sbesson
Copy link
Member

sbesson commented Nov 20, 2014

See https://github.com/openmicroscopy/snoopycrimecop/blob/v0.6.3/scc/git.py#L1634. This method should likely be changed to store (user, repo) tuples using the PR information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants