-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test in travis #136
Merged
Merged
Test in travis #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally passing with:
Let's see what travis says! |
Kaching |
6 tasks
Merging. As per https://trello.com/c/65fh1AUq/48-remove-pytest-command-and-clipy, I'm going to delay trying to remove |
@joshmoore 2dff8d7 and 3674b20 will need to be extracted since we now have the same problem on the newly created worfklows branch and on #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, all scripts are tested in travis instead of OMERO.
This should prevent the failure we have in main CI (movie test is off) or devspace CI (driver for that investigation)
The file
script.py
has been copied from OMERO but this should be available fromtestlib
A PR will be required in OMERO in order to change that.
The test for make_movie is marked as broken due to a codec issue.
see https://trello.com/c/AlN5hp6g/144-make-movie-tests-failures
Using another encoder will be a good idea but it is not a top priority at the moment.
I am not planning to do so in this PR.
cc @sbesson @joshmoore
Such strategy could be used too in https://github.com/openmicroscopy/omero-example-scripts