Resolved unit tests failures for test_bess.py and placement_constrain… #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.py Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
5 tasks
gab-arrobo
approved these changes
Mar 9, 2024
Comment on lines
-89
to
+96
| nat = NAT(ext_addrs=nat_config) | ||
|
|
||
| # This test verifies the scheduling constraint of a module when we | ||
| # schedule more workers than the maximum allowed workers for it. | ||
| # As part of the commit a742ee6e356d27175dd09af85e970a037aa14a59 | ||
| # the max_allowed_workers_ was increased to 2 from 1 and it causes | ||
| # this test to fail. In order to resolve this issue using the | ||
| # StaticNAT() module to validate this constraint. Later need to | ||
| # understand the reason for increasing max_allowed_workers_ for | ||
| # NAT module |
There was a problem hiding this comment.
@sureshmarikkannu, please let's open an issue so we can keep track of this change/issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.