Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA for staticcheck and address issues #57

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

gab-arrobo
Copy link
Contributor

@gab-arrobo gab-arrobo commented Aug 29, 2024

Tested changes with OnRamp using the replace directive in the amf and smf go modules (Docker images)
The changes in this PR address the issues shown by staticcheck

$ staticcheck ./...
proto/client/gClient.go:38:2: field sst is unused (U1000)
proto/client/gClient.go:39:2: field sd is unused (U1000)
proto/client/gClient.go:143:35: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x.  (SA1019)
proto/client/gClient.go:144:14: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x.  (SA1019)
proto/client/gClient.go:219:6: func readConfigInLoop is unused (U1000)
proto/client/gClient.go:222:2: should use for range instead of for { select {} } (S1000)

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@thakurajayL thakurajayL merged commit 8b1c6c4 into omec-project:main Aug 29, 2024
7 checks passed
@gab-arrobo gab-arrobo deleted the gha-staticcheck branch August 29, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants