-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow registration to PLMNID other than 208-93 #119
Conversation
Can one of the admins verify this patch? |
HI @yoursunny . Thank you for your contribution. We are happy to have you as a contributor. Can you please singup for CLA agreement. Thank you. |
@gab-arrobo : can you add your comment about lint errors? Also Unit test job name - unit-test-pfcpiface seems wrong.. We should remove pfcpiface. |
Let me take a closer look at it. However, in general, we need to refactor the GHAs to be aligned with the rest of the SD-Core repos |
@thakurajayL please review PR #120. That should fix the issue with lint here. However, we still need to enable several more lints in the .golanci.yml file |
Hi @yoursunny could you please help me with details like what core netork you used to test this PR ? Thanks. |
This was tested with Open5GCore. |
I'm now testing with free5GC. |
Could you please update README as well. So it highlights that this tool is used against free5gc, open5g core? |
This is now mostly working with free5GC including registration and PDU session. free5GC is rejecting ServiceRequest procedure due to #126 . Open5GCore has more complications, see #125 , so that it would not work at the moment.
README doesn't have a section on interoperability, and the implementation isn't fully working for all procedures, so that I'd rather not. |
This patch fixes several bugs in UE and gNB, to make it possible to register the UE to a core network with MCC=001 MNC=01.
This has been tested with free5GC, for uetriggservicereq and deregister procedures. Test log: free5gc.zip
Resolves #68.
Closes #88.
initImsi
and other places in profile packageThe IMSI is converted to integer and back to string without preserving its length.
When MCC is set to 001, this removes the leading zeros, resulting in mismatched IMSI.
SupiToSuci
MCC and MNC are searched, separately, in the IMSI.
When MNC happens to be a substring of MCC, this results in incorrect MSIN.
For example, an input of "imsi-001017005551000" would result in MSIN "017005551000" instead of "7005551000".
SN_NAME
208-93 was hard-coded in
SN_NAME
constant.This is replaced with a dynamic construction according to UE's PLMNID.
HandleInitialUEMessage
and other places in gnbcpueworker packagengapTestpacket package generates messages with hard-coded 208-93 TAC=1 in UserLocationInformation IE.
This is wrapped with updating procedures in gnodeb/ngap package.