api to run configured profiles #74
Conversation
| @@ -37,7 +37,7 @@ docker-build: | |||
| . \ | |||
| || exit 1; \ | |||
| done | |||
| sudo rm -rf vendor | |||
| rm -rf vendor | |||
There was a problem hiding this comment.
Wondering why we had added sudo. and do you see any issues with sudo ?
There was a problem hiding this comment.
not sure when we added it. but when we try to run on the laptop with sudo it asks for password. so thought better to remove it. not needed in any case.
profile/httprouter/handler.go
Outdated
| func HTTPExecuteConfigProfile(c *gin.Context) { | ||
|
|
||
| logger.HttpLog.Infoln("ExecuteConfigProfile API called") | ||
| //var prof profCtx.Profile |
There was a problem hiding this comment.
Do you want to get rid of commented code ?
profile/httprouter/handler.go
Outdated
| profileWaitGrp.Wait() | ||
| } | ||
|
|
||
| c.JSON(http.StatusOK, gin.H{}) |
There was a problem hiding this comment.
I realized yesterday that if profile takes lot of time then GUI waits for long time. Perhaps you respond to GUI immediately and then continue execution in background. If new API request comes while previous execution is still in progress then response with 200 again.
There was a problem hiding this comment.
we should send the result of the execution in the response. had done it in the gui branch. will merge to this. its better than sending empty response.
badhrinathpa
force-pushed
the
demo3_updates
branch
from
3ee02ff
to
7cc9d1c
Compare
badhrinathpa
force-pushed
the
demo3_updates
branch
from
7cc9d1c
to
a0e5dfa
Compare
No description provided.