Check if PFCP Agent is up by trying to setup association and use established association for all test cases #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2022 18:10
…shed association for all test cases
added 2 commits
March 8, 2022 18:14
ccascone
previously approved these changes
Mar 8, 2022
test/integration/framework.go
Outdated
| func waitForPFCPAgentToStart() error { | ||
| return waitForPortOpen("udp", "127.0.0.1", "8805") | ||
| // waitForPFCPAgentToStart checks if PFCP Agent is started by trying to create PFCP association. | ||
| // It retries every 5.5 seconds (0.5 seconds of interval between tries + 5 seconds that PFCP Client waits for response). |
There was a problem hiding this comment.
Would it be useful to allow passing the timeout as a parameter to pfcpClient.SetupAssociation()? A period of 5.5 seconds means that we might be introducing a delay of 5.5 seconds to each test if the first association is sent before the pfcp-agent is ready (which I assume to be likely) -- right?
There was a problem hiding this comment.
Yes, that's right. I'll modify the pfcpsim - I think it would be useful.
|
Depends on #560. We didn't see that before because integration tests were waiting 5 seconds for the response. Now, they wait only 1 second. |
pudelkoM
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.