Remove internal application and release ID if not used by any UE session #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into app-id-release
…into app-id-release
ccascone
previously approved these changes
Mar 25, 2022
pfcpiface/up4.go
Outdated
|
|
||
| applicationsEntry, err := up4.p4RtTranslator.BuildApplicationsTableEntry(pdr, up4.conf.SliceID, newAppID) | ||
| if err != nil { | ||
| releaseID() |
There was a problem hiding this comment.
just curious, when not just calling up4.unsafeReleaseInternalApplicationID(appFilter) instead of defining a new function?
pfcpiface/up4.go
Outdated
| appFilter.appProto = pdr.appFilter.proto | ||
|
|
||
| if up4Application, exists := up4.applicationIDs[appFilter]; exists { | ||
| // application already exists, increment ref count. |
pfcpiface/up4.go
Outdated
Comment on lines
856
to
869
| var appFilter up4ApplicationFilter | ||
| if pdr.IsUplink() { | ||
| app = application{ | ||
| appFilter = up4ApplicationFilter{ | ||
| appIP: pdr.appFilter.dstIP, | ||
| appL4Port: pdr.appFilter.dstPortRange, | ||
| } | ||
| } else if pdr.IsDownlink() { | ||
| app = application{ | ||
| appFilter = up4ApplicationFilter{ | ||
| appIP: pdr.appFilter.srcIP, | ||
| appL4Port: pdr.appFilter.srcPortRange, | ||
| } | ||
| } | ||
|
|
||
| app.appProto = pdr.appFilter.proto | ||
| appFilter.appProto = pdr.appFilter.proto |
There was a problem hiding this comment.
I already saw this in addInternalApplicationIDAndGetP4rtEntry. To reduce duplication, I suggest extracting into a function.
added 2 commits
March 25, 2022 13:40
…into app-id-release
added 3 commits
March 25, 2022 13:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: