Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .out files to be generated in other directories #31

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Conversation

lhchavez
Copy link
Member

@lhchavez lhchavez commented Oct 1, 2020

This allows for .out files to be generated in directories other than
cases/. This is useful in CI contexts.

This change returns the common LiteralInput in the ci.TestConfig. This
is needed because the OutGeneratorConfig is going to have a different
Input so that it can create .out files outside of the cases/ directory.
This allows for .out files to be generated in directories other than
`cases/`. This is useful in CI contexts.
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #31 into master will decrease coverage by 1.39%.
The diff coverage is 35.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   42.69%   41.29%   -1.40%     
==========================================
  Files          25       25              
  Lines        5661     5279     -382     
==========================================
- Hits         2417     2180     -237     
+ Misses       2987     2846     -141     
+ Partials      257      253       -4     
Impacted Files Coverage Δ
runner/sandbox.go 22.94% <0.00%> (-0.42%) ⬇️
runner/ci/ci.go 47.29% <40.00%> (+0.17%) ⬆️
common/problemfiles.go 61.06% <0.00%> (-5.04%) ⬇️
grader/context.go 64.70% <0.00%> (-2.87%) ⬇️
common/context.go 60.91% <0.00%> (-2.72%) ⬇️
common/literalinput.go 25.40% <0.00%> (-2.14%) ⬇️
cmd/omegaup-grader/ci.go 56.37% <0.00%> (-1.47%) ⬇️
grader/queue.go 49.55% <0.00%> (-1.46%) ⬇️
common/run.go 4.00% <0.00%> (-1.36%) ⬇️
common/problemsettings.go 54.08% <0.00%> (-1.19%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37d6b3...1a91b36. Read the comment docs.

@lhchavez lhchavez merged commit 6b5e5bb into master Oct 1, 2020
@lhchavez lhchavez deleted the other-outs branch October 1, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant