Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extra user agent #67

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Support extra user agent #67

merged 2 commits into from
Sep 22, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Sep 21, 2023

Support extra user agent

result := &omise.Account{}

// pass extra user agent
client.WithUserAgent("OmiseShopify/2.0.0 CheckoutPage/1.0.0") 

err := client.Do(result, &operations.RetrieveAccount{})

Above code will become user agent as OmiseShopify/2.0.0 CheckoutPage/1.0.0 OmiseGo/1.0.12 Go/go1.21

@ajzkk ajzkk self-assigned this Sep 21, 2023
Copy link
Contributor

@nuxzero nuxzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this impact to Superset's analytics?

client_test.go Outdated Show resolved Hide resolved
@ajzkk ajzkk requested a review from nuxzero September 21, 2023 10:02
@aashishgurung
Copy link
Contributor

aashishgurung commented Sep 21, 2023

I was thinking we could use WithCustomHeaders for this but with this in place, we might not need it. Do we find any use case for WithCustomHeaders? If not then let's remove it.

Or maybe not since there might be people using it although I highly doubt it.

@ajzkk ajzkk requested a review from a team September 21, 2023 10:24
@danfowler danfowler changed the title [MIT-1745] Support extra user agent Support extra user agent Sep 21, 2023
@ajzkk ajzkk merged commit 774eb20 into master Sep 22, 2023
7 checks passed
@danfowler danfowler deleted the MIT-1745-support-extra-user-agent branch October 26, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants