Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Capabilities parser for unsupported types (v4.27.0) #254

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fixed Capabilities parser for unsupported types (v4.27.0) #254

merged 1 commit into from
Jan 22, 2024

Conversation

vault087
Copy link

@vault087 vault087 commented Jan 16, 2024 •
edited
Loading

Capabilities parsing was failing if unsupported Card Brand appears in the list (e.g. UnionPay).

  • UnionPay was added to capabilities.json mock file
  • Card Brand and Capabilities were refactored to make current unit tests pass

@danfowler danfowler requested a review from a team January 16, 2024 09:51
@vault087 vault087 merged commit 3247b16 into support/v4.27.0 Jan 22, 2024
4 checks passed
@vault087 vault087 deleted the feature/MIT-2225-Capabilities-v4 branch January 22, 2024 01:18
@vault087 vault087 mentioned this pull request Jan 25, 2024
Merged
@vault087 vault087 changed the title Prevent SDK from failing during Capabilities parsing (v4.27.0) Fixed Capabilities parser for unsupported types (v4.27.0) Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfowler danfowler danfowler approved these changes

@aashishgurung aashishgurung aashishgurung approved these changes

@AnasNaouchi AnasNaouchi Awaiting requested review from AnasNaouchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vault087 @danfowler @aashishgurung