provide fpx logo in checkout screen #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimitomise
requested review from
Ashraf-alkibsi,
jacstn,
FhanOmise,
hpariwat,
kan98,
tookaa2 and
jutinapas
tookaa2
approved these changes
Dec 1, 2021
| @@ -71,6 +65,12 @@ | |||
| </fieldset> | |||
| </form> | |||
| <div class="actions-toolbar"> | |||
| <div class="checkout-agreements-block"> | |||
| <span>clicking on tht "Place Order" button, you agree to FPX's</span> | |||
There was a problem hiding this comment.
Suggested change
| <span>clicking on tht "Place Order" button, you agree to FPX's</span> | |
| <span>By clicking on the "Place Order" button, you agree to FPX's</span> |
FhanOmise
approved these changes
Dec 1, 2021
hpariwat
approved these changes
Dec 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Regarding to FPX CI so FPX request Omise to display their payment method under the checkout screen with FPX logo and also display a link to their term and conditions page.
Related information:
https://omise.atlassian.net/browse/APM2-206
2. Description of change
3. Quality assurance
FPX logo along with term and condition link displayed on checkout screen for Malaysia merchant whose enable FPX payment method.
🔧 Environments:
Platform version: Magento CE 2.2.3.
Omise plugin version: Omise-Magento 2.2.0
PHP version: 7.0.16.
✏️ Details:
4. Impact of the change
None
5. Priority of change
High