[FRON-972] #326

timothyOmise · 2022-02-18T03:27:38Z

1. Objective

Currently the magento plugin has 2 flows that will create and send invoices when merchant is using 3ds (redirect & webook). This PR aims to mitigate this issue by delaying the creation and sending of the invoices by 10secs when initiated via webhook. This delay should allow time for any redirect process to complete and update the order records to reflect that the invoice for the order has been created and sent already.

2. Description of change

A delay has been added above the 'sendInvoiceEmail' method that is called in the PendingInvoiceHandler Class handler method. The creation of the invoice from the PendingInvoiceHandler Class handler method has been moved inside the 'sendInvoiceEmail' method. A 2nd argument has been added to the 'sendInvoiceEmail' to flagh whether or not to created the invoice before sending.

A slight updated to 'Omise\Payment\Model\Api\Capabilities' class has been made. The purpose of this is to pass the exception message to the custom exception 'LocalizedException' to allow for better error debugging for interrogations.

3. Quality assurance

3DS checkout process needs to be tested. Ensure that only 1 invoice is created and sent. As we fixing a race condition there may still be very rare edge cases that still send and create 2 invoices. Therefore a 99% success rate is acceptable.

🔧 Environments:

Local php development env

i.e.

Platform version: Magento CE 2.4.3.
Omise plugin version: Omise-Magento 2.20.5.
PHP version: 7.4.27.

✏️ Details:

Created a order with 3DS enabled and conffirm that only 1 invoice is created and sent

4. Impact of the change

N/A

5. Priority of change

High

…r an invoice has been already sent or not

…er' for 10secs, move creation of new invoice from 'PendingInvoiceHandler' to 'sendInvoiceEmail' method, new invoice will only be created in 'sendInvoiceEmail' method when 2nd arg is true and the order object has no invoices registered