Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-808] : Allow hosts config #169

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Jan 17, 2023

Objective

Allow hosts config and added missing source retrieve function

#ENGA3-808

Description

  • Allow hosts config to switch staging url.
import Omise from "omise";

const config = {
    host: "api.xxxxxxx.co",
    vaultHost : "vault.xxxxxxx.co",
    publicKey:    "pkey_*****************",
    secretKey:    "skey_*****************",
    omiseVersion: "2019-05-29",
};
  
const omise = Omise(config)
  • Check response is valid json and reject promise if not valid.
  • Add types to support hosts
  • Added missing source retrieve function omise.sources.retrieve('src_xxxxxx')

@ajzkk ajzkk self-assigned this Jan 17, 2023
@ajzkk ajzkk force-pushed the feature/ENGA3-808-allow-host-config branch from ac39941 to 2af1084 Compare January 17, 2023 07:59
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ajzkk ajzkk merged commit f0bafa3 into master Jan 19, 2023
@ajzkk ajzkk deleted the feature/ENGA3-808-allow-host-config branch January 26, 2023 06:28
@ajzkk ajzkk mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants