Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added status to ICharge interface. #213

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Added status to ICharge interface. #213

merged 3 commits into from
Apr 22, 2024

Conversation

aashishgurung
Copy link
Contributor

Description

Added missing status to the ICharge interface.

Related links:

Decision(s)

  • Created a type ChargeStatus for type safety.

Rollback procedure

default rollback procedure

@aashishgurung aashishgurung merged commit c635aeb into master Apr 22, 2024
8 checks passed
@aashishgurung aashishgurung deleted the add_status_to_ICharge branch April 22, 2024 09:53
@aashishgurung aashishgurung mentioned this pull request May 23, 2024
Merged
aashishgurung added a commit that referenced this pull request May 23, 2024
@aashishgurung
Release v0.12.1 (#217)
f1baa92 
## Description

Metadata updated for the release of v0.12.1

**What's changed**
- Status added to ICharge interface.
[(#213)](#213)
 
## Rollback procedure

`default rollback procedure`

Co-authored-by: Aashish <aashish@omise.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnasNaouchi AnasNaouchi AnasNaouchi approved these changes

@vault087 vault087 vault087 approved these changes

@gaurab13 gaurab13 gaurab13 approved these changes

@mmkittisak mmkittisak Awaiting requested review from mmkittisak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aashishgurung @gaurab13 @vault087 @AnasNaouchi