Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed logging secret key in clear text #56

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Removed logging secret key in clear text #56

merged 1 commit into from
Nov 22, 2022

Conversation

Sim4n6
Copy link
Contributor

@Sim4n6 Sim4n6 commented Nov 11, 2022 •
edited
Loading

I would suggest the deletion of the two code lines that log the secret key in clear text.

in link with H1 report 1662194 and #55

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aashishgurung aashishgurung merged commit dfdc649 into omise:master Nov 22, 2022
@Sim4n6 Sim4n6 deleted the patch-1 branch November 22, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajzkk ajzkk ajzkk approved these changes

@aashishgurung aashishgurung aashishgurung approved these changes

@davidhanh davidhanh Awaiting requested review from davidhanh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sim4n6 @aashishgurung @ajzkk