Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENGA3-709] : bug fixed on remember card if user not logged in #349

Merged
merged 2 commits into from
Mar 1, 2023
Merged

[ENGA3-709] : bug fixed on remember card if user not logged in #349

merged 2 commits into from
Mar 1, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Feb 28, 2023

1. Objective

Bug fixed on remember card if user not logged in

#348 Previous PR

2. Description of change

  • Hide remember card option if user not logged in

3. Quality assurance

Tested Locally

4. Impact of the change

N/A

5. Priority of change

Normal

@ajzkk ajzkk requested a review from danfowler February 28, 2023 09:38
@ajzkk
Update omise-payment-form-handler.js
3dc9f21 
Co-authored-by: Daniel Fowler <daniel@omise.co>
@ajzkk ajzkk merged commit 9738930 into master Mar 1, 2023
@ajzkk ajzkk deleted the bug/ENGA3-709-remember-card branch March 1, 2023 04:17
ajzkk added a commit that referenced this pull request Mar 7, 2023
@ajzkk
Revert "[ENGA3-709] : bug fixed on remember card if user not logged in (
0f446f2 
#349)"

This reverts commit 9738930.
@ajzkk ajzkk mentioned this pull request Mar 7, 2023
Closed
danfowler added a commit that referenced this pull request Mar 8, 2023
@danfowler
Revert "[ENGA3-709] : bug fixed on remember card if user not logged in (
0b8f3c0 
#349)"

This reverts commit 9738930.
ajzkk added a commit that referenced this pull request Mar 8, 2023
@ajzkk @danfowler
Reverts embedded form (#351)
958a9fe 
* Revert "[ENGA3-709] : bug fixed on remember card if user not logged in (#349)"

This reverts commit 9738930.

* Revert "[ENGA3-709] Replace credit card form with pay.js embedded form (#348)"

This reverts commit cb136fc.

---------

Co-authored-by: Daniel Fowler <daniel@opn.ooo>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfowler danfowler danfowler approved these changes

@aashishgurung aashishgurung Awaiting requested review from aashishgurung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajzkk @danfowler