Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed secure form not show in pay for order page #371

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Apr 26, 2023

1. Objective

Bug fixed secure form not show in pay for order page

2. Description of change

  • Secure form not show on pay for order page because updated_checkout event was never trigger from checkout page. So, we need to call showOmiseEmbeddedCardForm on page loaded.
  • We also still need to call showOmiseEmbeddedCardForm under updated_checkout event since the secure form is disappeared on normal checkout page when checkout form is updated.

Screenshot 2023-04-26 at 12 50 08 PM

3. Quality assurance

  • Create order from admin panel and click on customer payment page under order detail section.
  • Select credit card and it show show secure form. (Make sure you have enabled secure form in opn payment setting.)

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

@ajzkk ajzkk merged commit bc6bbbf into develop Apr 26, 2023
@ajzkk ajzkk mentioned this pull request May 11, 2023
@ajzkk ajzkk deleted the bug/ENGA3-1149-bug-secure-form branch July 26, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants