This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Supports passing exchange pair's rate as string #1000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #996
Closes: #996
Overview
This PR add supports for exchange pair's creation and update by passing the rate as a string.
Changes
EWallet.ExchangePairGate
Implementation Details
This is a small update to the
ExchangePairGate
that tries to parse a string rate before doing the insert/update.A caveat is that this uses
Float.parse/1
which means that there could be precision loss in the floating point returned. But since the DB is already storing the rate as a floating point, this does not introduce more precision loss than it already is. The precision loss is #998.Usage
Impact