Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Frontend plasma transfers #1165

Closed
wants to merge 8 commits into from

Conversation

nicholasmueller
Copy link
Contributor

@nicholasmueller nicholasmueller commented Sep 24, 2019

Issue/Task: 990

Overview

Send transaction on plasma from internal wallet to any external address
Deposit to plasma from a cold wallet

Usage

run elixir-omg and set OMISEGO_CONTRACT_ADDRESS in eth_omisego_adapter in elixir and plasmaContractAddress in frontend /src/omg-plasma/config.js

For internal => external on plasma

  • make sure you have plasma balance in hot wallet
  • make sure an internal primary wallet has a blockchain deposit address with a balance
  • wallets page -> primary wallet -> external transfer button -> select token and option to transfer on plasma
  • you can see it working by sending to a registered cold wallet and the plasma balance should increase (blockchain wallets -> cold wallet detail)

For cold wallet => deposit to plasma

  • make sure cold wallet has balance
  • transfer -> select "to OmiseGO Network" -> confirm in metamask -> wait
  • omg-js doesnt support callbacks during the lifecycle of the transaction so i shortcut the usual transfer flow (with pending and confirmed states)

@unnawut
Copy link
Contributor

unnawut commented Oct 3, 2019

Note that this is purely code review. Didn't try running.

@@ -3,7 +3,8 @@ export default {
web3ProviderUrl: 'http://localhost:8545',
watcherUrl: 'http://localhost:7434',
childchainUrl: 'http://localhost:9656',
plasmaContractAddress: '0xb0df2ea778e5ddc6c85d25fbed335e67211a15b5',
plasmaContractAddress: '0xc887b342280bd175bb66e1d9323df0d52a83611a',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we get this from some config somehow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be replaced with the blockchain config that is setup on backend @T-Dnzt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@T-Dnzt can i merge this and make new pr implementing O's blockchain settings?

@unnawut unnawut removed their request for review November 6, 2019 03:33
@mederic-p mederic-p removed their request for review January 21, 2020 07:22
@T-Dnzt T-Dnzt closed this Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants