This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnawut
reviewed
Oct 3, 2019
apps/frontend/assets/src/omg-create-blockchain-transaction-modal/index.js
Outdated
Show resolved
Hide resolved
apps/frontend/assets/src/omg-create-blockchain-transaction-modal/index.js
Outdated
Show resolved
Hide resolved
apps/frontend/assets/src/omg-transaction/CreateBlockchainTransactionButton.js
Show resolved
Hide resolved
Note that this is purely code review. Didn't try running. |
T-Dnzt
approved these changes
Oct 28, 2019
@@ -3,7 +3,8 @@ export default { | |||
web3ProviderUrl: 'http://localhost:8545', | |||
watcherUrl: 'http://localhost:7434', | |||
childchainUrl: 'http://localhost:9656', | |||
plasmaContractAddress: '0xb0df2ea778e5ddc6c85d25fbed335e67211a15b5', | |||
plasmaContractAddress: '0xc887b342280bd175bb66e1d9323df0d52a83611a', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we get this from some config somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be replaced with the blockchain config that is setup on backend @T-Dnzt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@T-Dnzt can i merge this and make new pr implementing O's blockchain settings?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task: 990
Overview
Send transaction on plasma from internal wallet to any external address
Deposit to plasma from a cold wallet
Usage
run
elixir-omg
and setOMISEGO_CONTRACT_ADDRESS
ineth_omisego_adapter
in elixir andplasmaContractAddress
in frontend/src/omg-plasma/config.js
For internal => external on plasma
For cold wallet => deposit to plasma