Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Allows tokens & wallets to be disabled #443

Merged
merged 9 commits into from
Sep 3, 2018
Merged

Allows tokens & wallets to be disabled #443

merged 9 commits into from
Sep 3, 2018

Conversation

T-Dnzt
Copy link

@T-Dnzt T-Dnzt commented Aug 30, 2018

Issue/Task Number: 434
closes #434

Overview

Since we can't delete tokens and wallets, we need to have the next best thing: an enabled property! Once disabled (enabled = false), a token/wallet will still be shown, but will not be usable for anything, unless it is re-enabled later.

Changes

  • Add enabled to tokens
  • Add enabled to wallets
  • Add new endpoints: /token.enable_or_disable and /wallet.enable_or_disable
  • Add tests at the controller and gate levels

@ghost ghost assigned T-Dnzt Aug 30, 2018
@ghost ghost added the s2/wip 🚧 label Aug 30, 2018
@T-Dnzt T-Dnzt added this to the v1.1 milestone Aug 30, 2018
@T-Dnzt T-Dnzt added kind/enhancement 🚀 New feature or request and removed s2/wip 🚧 labels Aug 30, 2018
unnawut
unnawut approved these changes Sep 3, 2018
View reviewed changes
apps/admin_api/test/admin_api/v1/controllers/admin_auth/wallet_controller_test.exs Outdated
@@ -591,4 +594,62 @@ defmodule AdminAPI.V1.AdminAuth.WalletControllerTest do
assert length == 3
end
end

describe "/wallet.disable" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wallet.enable_or_disable

@unnawut
Copy link
Contributor

unnawut commented Sep 3, 2018

Notes for future reference:

This enable/disable switches are under their own endpoints and not part of i.e. /token.update because they have a significant impact on the overall system (e.g. cannot perform transactions, etc.)

@unnawut unnawut removed their assignment Sep 3, 2018
@T-Dnzt T-Dnzt force-pushed the 434-allows-tokens-wallets-disabled branch from c869f36 to 4a4991f Compare September 3, 2018 10:32
@ghost ghost added the s2/wip 🚧 label Sep 3, 2018
@T-Dnzt T-Dnzt removed the s2/wip 🚧 label Sep 3, 2018
@T-Dnzt T-Dnzt merged commit cd5d62f into master Sep 3, 2018
@T-Dnzt T-Dnzt deleted the 434-allows-tokens-wallets-disabled branch September 3, 2018 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unnawut unnawut unnawut approved these changes

@mederic-p mederic-p Awaiting requested review from mederic-p

Assignees

@T-Dnzt T-Dnzt

@mederic-p mederic-p

Labels
kind/enhancement 🚀 New feature or request
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Allow tokens /wallets to be disabled.
3 participants
@T-Dnzt @unnawut @mederic-p