Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make title of the page configurable through the .env file #199

Closed
akolotov opened this issue Mar 27, 2019 · 0 comments
Closed

Make title of the page configurable through the .env file #199

akolotov opened this issue Mar 27, 2019 · 0 comments
Assignees
@gabitoesmiapodo

Comments

@akolotov
Copy link
Collaborator

akolotov commented Mar 27, 2019 •
edited
Loading

There is a need to change the page title depending on the token bridge intention.

Consider to add a new parameter REACT_APP_TITLE that will describe the rule of the title generation in form of:

REACT_APP_TITLE=Some text - %c

If the template %c is specified, the actual title will be displayed with the chain currently chosen. E.g. Some text - POA Network.
If the template %c is omitted the network name is not displayed.
if the template is specified but the network is not chosen (e.g. the NW extension is not set up), the following must be displayed: Some text - No chain specified
@gabitoesmiapodo gabitoesmiapodo self-assigned this Mar 27, 2019
gabitoesmiapodo added a commit that referenced this issue Mar 27, 2019
@gabitoesmiapodo
Merge branch 'develop' into feature/#199-make-title-of-the-page-confi…
f3ec02a 
…gurable

* develop:
  (fix) changed <Link> to <a> on social icons.
@ghost ghost added the in progress label Mar 27, 2019
@gabitoesmiapodo gabitoesmiapodo mentioned this issue Mar 27, 2019
Merged
@ghost ghost added review and removed in progress labels Mar 27, 2019
gabitoesmiapodo added a commit that referenced this issue Mar 27, 2019
@gabitoesmiapodo
Merge branch 'develop' into feature/#199-make-title-of-the-page-confi…
fe4a700 
…gurable

* develop:
  Remove console.log
  Fix on TxStore
  Web3 fixes
  Update react build dependencies
  Fix on getBridgeValidators
  Update e2e test script
  Update parity version on e2e tests
  Use getChainId method from web3
  Fixes for new web3 version
  Update web3 version

# Conflicts:
#	src/stores/utils/web3.js
akolotov added a commit that referenced this issue Mar 27, 2019
@akolotov
Merge pull request #201 from poanetwork/feature/#199-make-title-of-th…
5511958 
…e-page-configurable

(Feature) Make title of the page configurable
@ghost ghost removed the review label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabitoesmiapodo @akolotov