Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #139 into develop 1.x #162

Merged
merged 8 commits into from
Dec 18, 2018
Merged

Backport #139 into develop 1.x #162

merged 8 commits into from
Dec 18, 2018

Conversation

fernandomg
Copy link

Closes #161

This is a backport to 9651de4 with changes introduced in #139

@ghost ghost assigned fernandomg Dec 18, 2018
@netlify
Copy link

netlify bot commented Dec 18, 2018 •
edited

Deploy preview for kind-kilby-95344f processing.

Built with commit fea042c

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c19396cb4a31000084ad893

patitonar
patitonar reviewed Dec 18, 2018
View reviewed changes
Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes Looks good. One comment is that in this version of bridge-ui, e2e test are not using docker. So I think e2e-script/docker-compose.yml, e2e-script/parity/Dockerfile and e2e-script/parity/Dockerfile-foreign should not be included.

@ghost ghost added the in progress label Dec 18, 2018
@fernandomg
Copy link
Author

The changes Looks good. One comment is that in this version of bridge-ui, e2e test are not using docker. So I think e2e-script/docker-compose.yml, e2e-script/parity/Dockerfile and e2e-script/parity/Dockerfile-foreign should not be included.

@patitonar done, please check.

@akolotov akolotov merged commit 449a5cb into develop-1.x Dec 18, 2018
@ghost ghost removed the in progress label Dec 18, 2018
@akolotov akolotov removed the review label Dec 18, 2018
@akolotov akolotov mentioned this pull request Dec 24, 2018
Closed
@akolotov akolotov deleted the backport-#139-into-develop-1.x branch May 24, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@akolotov akolotov akolotov approved these changes

Assignees

@fernandomg fernandomg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fernandomg @patitonar @akolotov