Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask #139

Closed
varasev opened this issue Oct 4, 2018 · 0 comments
Closed

(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask #139

varasev opened this issue Oct 4, 2018 · 0 comments
Assignees
@fernandomg @patitonar

Comments

@varasev
Copy link

varasev commented Oct 4, 2018

Problem: On November 2nd, 2018 MetaMask and other DApp browsers will stop exposing user accounts by default. Instead, dapps must request access using a new provider method: provider.enable(). Detailed info is available here: https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8

Solution: Fix the code which loads DApp according to instructions from What this means for developers section of the article mentioned above.
@patitonar patitonar self-assigned this Oct 5, 2018
@ghost ghost added the in progress label Oct 5, 2018
@patitonar patitonar mentioned this issue Oct 8, 2018
Merged
@ghost ghost added review and removed in progress labels Oct 8, 2018
akolotov referenced this issue Oct 17, 2018
@akolotov
Merge pull request #142 from poanetwork/support-metamask-change-#139
7f1390e 
Support Metamask changes
@akolotov akolotov mentioned this issue Dec 18, 2018
Closed
@ghost ghost assigned fernandomg Dec 18, 2018
@ghost ghost added the in progress label Dec 18, 2018
@fernandomg fernandomg removed the review label Dec 18, 2018
@fernandomg fernandomg mentioned this issue Dec 18, 2018
Merged
akolotov added a commit that referenced this issue Dec 18, 2018
@akolotov
Merge pull request #162 from poanetwork/backport-#139-into-develop-1.x
449a5cb 
Backport #139 into develop 1.x
@ghost ghost removed the in progress label Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fernandomg fernandomg

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fernandomg @patitonar @akolotov @varasev