Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask detection problem #161

Closed
rstormsf opened this issue Dec 18, 2018 · 5 comments
Closed

Metamask detection problem #161

rstormsf opened this issue Dec 18, 2018 · 5 comments
Assignees

Comments

@rstormsf
Copy link
Contributor

rstormsf commented Dec 18, 2018

image
2018-12-18 12 17 36

Metamask 5.2.2

@rstormsf
Copy link
Contributor Author

image

Production version doesn't align with master branch.
I don't see same source code such as ethereum.enable()
EIP1102
https://github.com/poanetwork/bridge-ui/blob/master/src/stores/utils/web3.js#L15

@akolotov
Copy link
Collaborator

@rstormsf thanks!
Right, the changes made for #139 were not backported to the old version to the Bridge UI.

@akolotov
Copy link
Collaborator

The suggestion is to do the following:

  1. Create two branches: master-1.x and develop-1.x based on 9651de4. The branch develop-1.x will be used for collecting and soaking backports and security updates. The branch master-1.x will be used for changes that need to go to https://bridge.poa.net (netlify auto deploy will be linked with this branch).
  2. Prepare a backport for (Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask #139 into develop-1.x. Link the branch develop-1.x with demo POA bridge in the Sokol network.
  3. As soon as everything is tested in develop-1.x merge the changes to master-1.x and produce the new release.

@rstormsf
Copy link
Contributor Author

@igorbarinov the bug is valid. the bridge was not working.

@akolotov
Copy link
Collaborator

Addressed in #162

@ghost ghost removed the review label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants