Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of EIP-1155 NFTs #24

Closed
akolotov opened this issue Apr 8, 2021 · 0 comments · Fixed by #29
Closed

Support of EIP-1155 NFTs #24

akolotov opened this issue Apr 8, 2021 · 0 comments · Fixed by #29
Labels
eip1155-token related to the eip1155 token contract implementation enhancement New feature or request mediators Related to mediators contracts

Comments

@akolotov
Copy link
Collaborator

akolotov commented Apr 8, 2021

Consider to support NFTs implemented with the EIP-1155 standard.

Several notes:

  1. Both single mode and batch mode must be supported. The batch mode must check that only NFTs (value=1) are being transferred through the bridge.
  2. Consider to have more than one minter allowed for the bridged token (e.g. through an intermediate minter contract). The main idea is to allow FT OB and NFT OB mint tokens on the same EIP1155 token contract.
  3. Consider the following implementation of meta-transactions
@akolotov akolotov added enhancement New feature or request eip1155-token related to the eip1155 token contract implementation labels Apr 8, 2021
@akolotov akolotov mentioned this issue Apr 8, 2021
Open
@akolotov akolotov added the mediators Related to mediators contracts label Apr 8, 2021
@k1rill-fedoseev k1rill-fedoseev mentioned this issue May 1, 2021
Merged
@akolotov akolotov mentioned this issue May 9, 2021
Merged
akolotov added a commit that referenced this issue May 9, 2021
@akolotov
Merge the develop branch to the master branch, preparation to v2.0.0-rc2
75902ce 
This update for the master branch contains the following set of changes:
  * [Improvement] Add support for ERC1155 (#28), closes #24
  * [Other] Fix stack too deep error in coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eip1155-token related to the eip1155 token contract implementation enhancement New feature or request mediators Related to mediators contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge the develop branch to the master branch, preparation to v2.0.0-rc2 omni/omnibridge-nft
1 participant
@akolotov