Problem: slow performance and regular timeouts sending transactions #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: fix the maximum number of concurrent HTTP request at a transport level. It is set by default to 64 and there's now a new configuration parameter (`concurrent_http_requests`) in `home` and `foreign` sections. Previously used `concurrency` parameter from transactions configuration has been removed.
ghost
assigned 
|
Run 2000 deposits with and without it.
…On Sun, Jun 3, 2018, 1:27 PM Alexander Kolotov ***@***.***> wrote:
***@***.**** commented on this pull request.
@yrashk <https://github.com/yrashk> could you please advice how to check
that this feature works?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#100 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABxHCtNCoEV8rLpwO_m53nhh6ihgvaks5t5EaVgaJpZM4UXf3w>
.
|
|
It is not clear for me what is expected?
…--
Alexander Kolotov
On Sun, Jun 3, 2018 at 11:29 PM Yurii Rashkovskii <notifications@github.com>
wrote:
Run 2000 deposits with and without it.
On Sun, Jun 3, 2018, 1:27 PM Alexander Kolotov ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> @yrashk <https://github.com/yrashk> could you please advice how to check
> that this feature works?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#100 (review)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAABxHCtNCoEV8rLpwO_m53nhh6ihgvaks5t5EaVgaJpZM4UXf3w
>
> .
>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT1HrNRllW4ZTvYWJVB6r64HnGW9XaLXks5t5Ec3gaJpZM4UXf3w>
.
|
|
One will either take very long time or just timeout, the other will process
them in a few seconds or so.
On Sun, Jun 3, 2018, 1:33 PM Alexander Kolotov <notifications@github.com>
wrote:
… It is not clear for me what is expected?
--
Alexander Kolotov
On Sun, Jun 3, 2018 at 11:29 PM Yurii Rashkovskii <
***@***.***>
wrote:
> Run 2000 deposits with and without it.
>
> On Sun, Jun 3, 2018, 1:27 PM Alexander Kolotov ***@***.***
>
> wrote:
>
> > ***@***.**** commented on this pull request.
> >
> > @yrashk <https://github.com/yrashk> could you please advice how to
check
> > that this feature works?
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
>
#100 (review)
> >,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AAABxHCtNCoEV8rLpwO_m53nhh6ihgvaks5t5EaVgaJpZM4UXf3w
> >
> > .
> >
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <
#100 (comment)>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AT1HrNRllW4ZTvYWJVB6r64HnGW9XaLXks5t5Ec3gaJpZM4UXf3w
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABxENWVp6UZqEOEZLUpdrq-XilJM9sks5t5EgdgaJpZM4UXf3w>
.
|
This was referenced Jun 13, 2018
noot
pushed a commit
to noot/poa-bridge
that referenced
this pull request
Jul 18, 2018
Problem: slow performance and regular timeouts sending transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: fix the maximum number of concurrent HTTP request
at a transport level.
It is set by default to 64 and there's now a new configuration
parameter (
concurrent_http_requests) inhomeandforeignsections. Previously used
concurrencyparameter from transactionsconfiguration has been removed.