Problem: bridge sends out transactions slowly #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because it is limiting them to one at a time per operation type. This was done so that there's no gaps in nonces due to undelivered transactions. Solution: allow concurrent sending of transactions By default, 100 transactions are allowed. Note, however, that now there's a chance that nonce gaps may be formed under cerain circumstances.
Solution: document it
ghost
assigned 
noot
pushed a commit
to noot/poa-bridge
that referenced
this pull request
Jul 18, 2018
* readme: add section on running truffle tests * extract `sign` from test/foreign into test/helpers and improve it * add test helper signatureToVRS * add test helper bigNumberToHexString * add test helper bigNumberToPaddedBytes32 * add test "should allow correct withdraw" which fails and exposes omni#61 * resolve omni#61 and document it * fix typo * fix typo * use num.toString(16) instead of bigNumberToHexString paritytech/parity-bridge#66 (comment) * add comment * use explicit transaction hash * add test "withdraw without funds on HomeBridge should fail" * add test "should not allow withdraw with message.length != 84" * add test ""should allow second withdraw with different transactionHash but same recipient and value" * add test "should not allow second withdraw with same transactionHash but different recipient and value" * fix typo * bridge.sol: add note that anyone can call HomeBridge.withdraw * test that anyone can call withdraw provided they have the message and signatures * test/home.js: improve wording of test
noot
pushed a commit
to noot/poa-bridge
that referenced
this pull request
Jul 18, 2018
Problem: bridge sends out transactions slowly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because it is limiting them to one at a time
per operation type. This was done so that there's no
gaps in nonces due to undelivered transactions.
Solution: allow concurrent sending of transactions
By default, 100 transactions are allowed.
Note, however, that now there's a chance that nonce
gaps may be formed under cerain circumstances.