Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml and Ansible linting in Molecule #141

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Yaml and Ansible linting in Molecule #141

merged 4 commits into from
Jul 11, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented Jul 10, 2019 •
edited
Loading

  • Enabled yamllint in molecule
    • Fixed linting errors
  • Enabled ansible-lint in molecule
    • Removed now-redundant ansible-lint job and ansible-lint.sh script
  • Progresses Add ansible-lint rules, fix linting errors #36
    • Does not close because we use only the minimal set of rules so there is room for improvement

@rzadp rzadp marked this pull request as ready for review July 10, 2019 13:51
@rzadp rzadp added the deployment related to deployment playbooks/scripts/configs label Jul 10, 2019
@rzadp rzadp merged commit 1da1acb into master Jul 11, 2019
@rzadp rzadp deleted the ansible-lint branch July 11, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArseniiPetrovich ArseniiPetrovich ArseniiPetrovich approved these changes

@akolotov akolotov akolotov approved these changes

@phahulin phahulin phahulin approved these changes

Assignees
No one assigned
Labels
deployment related to deployment playbooks/scripts/configs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rzadp @phahulin @akolotov @ArseniiPetrovich