Use header auth mode for user and email requests #84
Conversation
Authenticating using query parameters is deprecated: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
|
This appears to be the fix for: #83 |
|
@BobbyMcWho @supernova32 sorry for the ping, but the GitHub deprecation emails are particularly noisy, so a timely merge would be ❤️ . |
|
I'd be happy to merge, but I don't know who has the actual rubygems account to cut a release. |
|
According to https://rubygems.org/gems/omniauth-github It's @mbleigh and @tmilewski |
|
We'll see if they respond. I've tried reaching out to them on a couple other omniauth projects to release new versions, with no reply. |
|
Worst case, I think we can try to see with rubygems people. But let's wait a bit first. Also, maybe it's better to merge this now, so that people can point their Gemfile to the master rather than a fork. And then see about the release in a separate issue? |
|
Also, now that I look, I don't have write access for this repo, only omniauth/omniauth |
|
@BobbyMcWho thanks or reviewing the PR. I'll give you write access here as well. @DazWorrall thanks for submitting the fixes :) |
Fix authentication using query params deprecation. See omniauth/omniauth-github#84
…parameters $ docker-compose run --rm app bundle update omniauth-github See also omniauth/omniauth-github#84
Fixes #83 - authenticating using query parameters is deprecated:
https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters