Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use header auth mode for user and email requests #84

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@DazWorrall
Copy link
Contributor

DazWorrall commented Feb 4, 2020

@Firefishy

This comment has been minimized.

Copy link

Firefishy commented Feb 4, 2020

This appears to be the fix for: #83

@casperisfine

This comment has been minimized.

Copy link

casperisfine commented Feb 5, 2020

@BobbyMcWho @supernova32 sorry for the ping, but the GitHub deprecation emails are particularly noisy, so a timely merge would be ❤️ .

@BobbyMcWho

This comment has been minimized.

Copy link
Member

BobbyMcWho commented Feb 5, 2020

I'd be happy to merge, but I don't know who has the actual rubygems account to cut a release.

@casperisfine

This comment has been minimized.

Copy link

casperisfine commented Feb 5, 2020

@BobbyMcWho

This comment has been minimized.

Copy link
Member

BobbyMcWho commented Feb 5, 2020

We'll see if they respond. I've tried reaching out to them on a couple other omniauth projects to release new versions, with no reply.

@casperisfine

This comment has been minimized.

Copy link

casperisfine commented Feb 5, 2020

Worst case, I think we can try to see with rubygems people. But let's wait a bit first.

Also, maybe it's better to merge this now, so that people can point their Gemfile to the master rather than a fork. And then see about the release in a separate issue?

@BobbyMcWho

This comment has been minimized.

Copy link
Member

BobbyMcWho commented Feb 5, 2020

Also, now that I look, I don't have write access for this repo, only omniauth/omniauth

@supernova32 supernova32 merged commit 4aca7b6 into omniauth:master Feb 5, 2020
@supernova32

This comment has been minimized.

Copy link
Member

supernova32 commented Feb 5, 2020

@BobbyMcWho thanks or reviewing the PR. I'll give you write access here as well.

@DazWorrall thanks for submitting the fixes :)

potomak added a commit to tomatoes-app/tomatoes that referenced this pull request Feb 16, 2020
Fix authentication using query params deprecation.

See omniauth/omniauth-github#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.