Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Relax gem 'oauth2' dependency requirement #146

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

WaKeMaTTa
Copy link
Contributor

I want to use oauth 2.0.0, but I can't because the dependency requirement are to strict.

This Pull Request fixes that.

@WaKeMaTTa WaKeMaTTa marked this pull request as ready for review November 17, 2021 10:29
@BobbyMcWho
Copy link
Member

I'll need to look into the oauth2 releases and change log, and verify nothing breaks

@WaKeMaTTa
Copy link
Contributor Author

I'll need to look into the oauth2 releases and change log, and verify nothing breaks

I will do the same next week. If I find something I will report it here.

@stanhu
Copy link

stanhu commented Jun 18, 2022

I also submitted #153.

@BobbyMcWho @WaKeMaTTa I've been working on the 2.0 release for the oauth2 gem. I believe this gem should be fully compatible.

@BobbyMcWho
Copy link
Member

Thanks for the reminder

@BobbyMcWho BobbyMcWho merged commit 0b00383 into omniauth:master Jun 18, 2022
@stanhu stanhu mentioned this pull request Jun 18, 2022
@BobbyMcWho
Copy link
Member

This has been released in v1.8.0
release notes
rubygems

@stanhu
Copy link

stanhu commented Jun 19, 2022

@BobbyMcWho Thanks so much!

Would it be possible to tag 1.7.3 without the requirement to upgrade Omniauth to v2? It seems that we have a number of Omniauth dependencies that still are lagging support for v2: https://gitlab.com/gitlab-org/gitlab/-/issues/345785

@BobbyMcWho
Copy link
Member

release notes
rubygems

@stanhu
Copy link

stanhu commented Jun 19, 2022

@BobbyMcWho Thank you again for your prompt releases!

@WaKeMaTTa
Copy link
Contributor Author

Sorry, I forgot to post here our results.

We use my fork since Nov 2021 and it works totally fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants