Adding Connection Pool functionality to pool workers #187
+118
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aiomultiprocess is exceptionally good at scaling network requests. However, the abstraction of tasks to queues scheduled amongst pool workers makes it impossible to enable connection pools for each worker in the current state. Using aiohttp's requests method results in a new session being created for every request, which degrades performance.
This PR nests each pool workers target
.run()
function within an async context manager that creates an aiohttp clientsession and passes the session into the tasks args.The PR in its current state will need some clean up before it is ready for merge, but I wanted to submit as a WIP to see if a contribution such as this would even be considered.