Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include timing info in logged responses #2173

Merged
merged 2 commits into from Jun 12, 2021
Merged

Include timing info in logged responses #2173

merged 2 commits into from Jun 12, 2021

Conversation

@filipw
Copy link
Member

@filipw filipw commented Jun 11, 2021

If we log responses, we now do it with duration information.

For example:

        ************  Response (50.2536ms) ************ 
{
  "Request_seq": 6,
  "Command": "/codecheck",
  "Running": true,
  "Success": true,
  "Message": null,
  "Body": {
    "QuickFixes": []
  },
  "Seq": 416,
  "Type": "response"
}

or

        ************  Response (4.0503ms) ************ 
{
  "Request_seq": 125,
  "Command": "/completion/resolve",
  "Running": true,
  "Success": true,
  "Message": null,
  "Body": {
    "Item": {
      "Label": "Console",
      "Kind": 7,
      "Tags": null,
      "Detail": "",
      "Documentation": "```csharp\nclass System.Console\n```\n\nRepresents the standard input, output, and error streams for console applications\\. This class cannot be inherited\\.",
      "Preselect": false,
      "SortText": null,
      "FilterText": null,
      "InsertTextFormat": 1,
      "TextEdit": {
        "NewText": "Console",
        "StartLine": 10,
        "StartColumn": 12,
        "EndLine": 10,
        "EndColumn": 13
      },
      "CommitCharacters": [
        " ",
        "{",
        "}",
        "[",
        "]",
        "(",
        ")",
        ".",
        ",",
        ":",
        ";",
        "+",
        "-",
        "*",
        "/",
        "%",
        "&",
        "|",
        "^",
        "!",
        "~",
        "=",
        "<",
        ">",
        "?",
        "@",
        "#",
        "'",
        "\"",
        "\\"
      ],
      "AdditionalTextEdits": null,
      "Data": {
        "Item1": 2,
        "Item2": 44
      },
      "HasAfterInsertStep": false
    }
  },
  "Seq": 831,
  "Type": "response"
}
@filipw filipw merged commit da1e65b into master Jun 12, 2021
16 checks passed
@filipw filipw deleted the feature/log-timing branch Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants