Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASP-5048] Fix lead host parsing when the job runs in multiple nodes #344

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[ASP-5048] Fix lead host parsing when the job runs in multiple nodes #344

merged 2 commits into from
Apr 30, 2024

Conversation

julianaklulo
Copy link
Contributor

What

Fix the extraction of the lead host when the job runs in multiple nodes.

Why

The nodelist was being splitted by ,, but the nodelist comes inside square brackets, which was not returning the expected values.

Example: node-[1,2,3] was being parsed as node-[1 instead of node-1

Task: https://jira.scania.com/browse/ASP-5048

Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

@julianaklulo julianaklulo changed the base branch from main to release/3.2 April 30, 2024 17:34
@julianaklulo julianaklulo force-pushed the juliana/ASP-5048--fix-lead-host-parsing branch 2 times, most recently from c8af502 to 32dae4e Compare April 30, 2024 18:28
@julianaklulo julianaklulo force-pushed the juliana/ASP-5048--fix-lead-host-parsing branch from 32dae4e to 3bfd0be Compare April 30, 2024 18:48
fschuch
fschuch approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@fschuch fschuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I approved it as it is, but left an optional suggestion.

lm-agent/lm_agent/workload_managers/slurm/cmd_utils.py Outdated Show resolved Hide resolved
@julianaklulo julianaklulo merged commit 48f3358 into release/3.2 Apr 30, 2024
1 check passed
@julianaklulo julianaklulo deleted the juliana/ASP-5048--fix-lead-host-parsing branch April 30, 2024 20:32
julianaklulo added a commit that referenced this pull request Apr 30, 2024
@julianaklulo
[ASP-5048] Fix lead host parsing when the job runs in multiple nodes (#…
2b0bc71 
…344)

* ASP-5048 Fix bug when extracting the lead host from the nodelist

* ASP-5048 Raise exception if lead host is empty
@julianaklulo julianaklulo mentioned this pull request Apr 30, 2024
Merged
julianaklulo added a commit that referenced this pull request May 2, 2024
@julianaklulo
[ASP-5048] Fix lead host parsing when the job runs in multiple nodes (#…
9982334 
…344) (#346)

* ASP-5048 Fix bug when extracting the lead host from the nodelist

* ASP-5048 Raise exception if lead host is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschuch fschuch fschuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianaklulo @fschuch