Testing for gh.py #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the parameter needed for calling _do_request. Using urljoin allows for a user to either provide "/testing/route" or "testing/route" and they will function the same in the context of building the API. This is in an effort to simplify testing.
This commit adds the initial support for testing the GitHub portion of this project. Most of this code is done via mocking all the HTTP requests made to the GitHub API.
Removed the returned function call that is being mocked since we were not using it.
Adds a test to validate that the wait call runs accordingly.
This simplifies and consolidates the test_remove_runner tests into a single parameter driven test.
This consolidates and simplifies the do_request testing.
This simplifies and consolidates the create_runner_token tests to be simpler.
Moved to a top level import to reduce repetition and simplify import logic.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
dwhswenson
requested changes
May 28, 2024
There was a problem hiding this comment.
Pretty good start.
- Add smoke tests, where possible, to warn us if PyGithub's API changes. Since you test our logic in the existing tests, those tests can be just smoke tests.
- Looks like a TODO still to be implemented (which might simplify the associated test, as well?)
dwhswenson
reviewed
May 28, 2024
Updated get_runner test to ensure that we could check the instance correctly.
dwhswenson
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing for
gh.pymaking heavy use of mocks for the GitHub API calls. Additionally, this PR usesurljointo help fix some of the testing issues that can occur with URLs.