-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README should be updated that this lib requires node Express #23
Comments
Sorry for the delay. I'll have a look tomorrow evening to see what exactly is being referenced that is specific to express and get rid of it. Really shouldn't be. If nothing else, will at least try to adapt to other frameworks as well. |
Thanks @omsmith. It's anywhere in your methods that takes in a req object. This req object is formatted for Express. For example it references |
I should probably double check my commit numbers ;) |
Ha On Wed, Oct 22, 2014 at 4:27 PM, David Kosub notifications@github.com
Owen |
accept body as second parameter to valid_request and parse_request avoid express-specific features such as req#get and req.protocol add hapi-specific check to get url and protocol
fix(not-express) avoid being locked into express. closes #23
The README should be updated that this lib requires node Express. The lib requires a http req object that is unique to Express. I tried using Hapi and Connect alone but neither worked with this library.
The text was updated successfully, but these errors were encountered: