Desktop version #5
Conversation
There was a problem hiding this comment.
Hi @Omwomo ,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
To Highlight 💯
- Linters passing 👍
- Good implementation of desktop version 👍
Required Changes ♻️
- kindly consider adding a working link to your LinkedIn account under the author's section to make your readme more interactive while doing so consider removing the note under the license section as it was given as guidance to guide you not to be added on your readme doing so will make your readme professional
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| margin-top: -9%; | ||
| margin-left: -1%; | ||
| margin-right: 3%; | ||
| background-image: url(head-back.svg); |
There was a problem hiding this comment.
- kindly consider making sure that this background is all visible in your intro section like it is on the Figma design to make your work an exact duplicate of the given one
- your design
- Figma design
| @@ -1,7 +1,13 @@ | |||
| @media (min-width: 375px), (min-width: 768px) { | |||
| @media (min-width: 375px) { | |||
There was a problem hiding this comment.
- you did a good jo implementing the desktop version good job so far 👍 but there is something you are missing out . kindly consider going back to your mobile version and fixing it all cause it was messed up when developing the desktop version remember we have to have a desktop version after the mobile version is okay and it has to stay okay to meet the responsiveness requirements while doing so consider also removing the horizontal scroll in your mobile version design doing all the above will help you to meet the below requirement
…en't interfere with the mobile version
…yling to optimise the mobile and desktop version
There was a problem hiding this comment.
Hi @Omwomo 😊,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🎉🎉
- Following Figma design😊👌
- Use the semantics elements💯
- Nice design .🚀
- Use the flexbox to place the items 😃👍
Required Changes ♻️
- kindly consider adding a working link to your LinkedIn account under the author's section to make your readme more interactive while doing so consider removing the note under the license section as it was given as guidance to guide you not to be added on your readme doing so will make your readme professional👍
Check the comments under the review.
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <ul class="languange_list"> | ||
| <ul class="language_list"> |
There was a problem hiding this comment.
- As stated by the previous reviewer You did a good job implementing the desktop version good job so far 👍 but there is something you are missing out. kindly consider going back to your mobile version and fixing it all cause it was messed up when developing the desktop version remember we have to have a desktop version after the mobile version is okay and it has to stay okay to meet the responsiveness requirements while doing so consider also removing the horizontal scroll in your mobile version design doing all the above will help you to meet the below requirement
There was a problem hiding this comment.
Status: Approved ✔️
Hi @Omwomo
Your project is complete! Great job 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 
. Congratulations! 🎉💯🌟
Good Points 👍
- Descriptive Pull Request
- followed the design
- No linter errors
--- [optional] please consider removing the note under the license section as it was given as guidance to guide you not to be added on your readme doing so will make your readme professional👍
Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
| </ul> | ||
| <button class="buttons">see project</button> |
There was a problem hiding this comment.
- [optional] Great job fixing the mobile version as requested by previous reviewer. Please kindly try to implement the hover and pressed effect on all the buttons on the desktop version. This will ensure your design perfectly aligns with the Figma version.
~Updated the existing html in correspondence to the desktop version.
~styled the desktop version according to the figma template.
~used media query of min-width 768px for the desktop version.