Add the Administrative level to locations #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciremusyoka
force-pushed
the
1349-location-adm-levels
branch
from
c93b23c
to
d8d674f
Compare
peterMuriuki
reviewed
Apr 3, 2024
Comment on lines
19
to
29
| const parseFhirChildren = (rawNodeMap: ChildNodeList[]) => { | ||
| const parseFhirChildren = (rawNodeMap: ChildNodeList[], admLevel = 0) => { | ||
| return rawNodeMap.map((child) => { | ||
| // standardize the parsedHierarchy node structure to be similar for both | ||
| // root node and all other descendant nodes. | ||
| const { treeNode } = child; | ||
| const nextAdmLevel = admLevel + 1; | ||
| const parsedNode: ParsedHierarchyNode = { | ||
| ...treeNode, | ||
| children: parseFhirChildren(treeNode.children ?? []) as ParsedHierarchyNode[], | ||
| administrativeLevel: admLevel, | ||
| children: parseFhirChildren(treeNode.children ?? [], nextAdmLevel) as ParsedHierarchyNode[], |
There was a problem hiding this comment.
I feel iffy about adding the adminstrative level here for 2 reasons:
- it possibly duplicates information that already exists in the node
- There is no guarantee that
parseFhirChildrenwill only always be used to generate a tree starting with the the root fhir location.
| @@ -4,6 +4,7 @@ export const eusmServicePointCodeSystemUri = | |||
| export const snomedCodeSystemUri = 'http://snomed.info/sct'; | |||
| export const hl7PhysicalTypeCodeSystemUri = | |||
| 'http://terminology.hl7.org/CodeSystem/location-physical-type'; | |||
| export const administrativeLevelSystemUri = 'https://smartregister.org/codes/administrative-level'; | |||
There was a problem hiding this comment.
lets have this as http://smartregister.org/CodeSystem/administrative-level
ciremusyoka
force-pushed
the
1349-location-adm-levels
branch
from
63ac1d2
to
a4b34ac
Compare
This reverts commit 6fe0253.
ciremusyoka
force-pushed
the
1349-location-adm-levels
branch
from
b69cc53
to
91a9a9a
Compare
peterMuriuki
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1349
Changes included with this PR
Checklist