Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sample filter cases on a map #291

Merged
merged 2 commits into from
May 16, 2019
Merged

Conversation

ekigamba
Copy link
Contributor

This also enables fabric crashlytics for debug

Crashlytics is enabled for debug because we mainly provide the debug APK this being a sample application and not necessarily one to put on the store.

All the code is also open source

Fixes #289

This also enables fabric crashlytics for debug

Fixes #289
@ekigamba ekigamba requested a review from githengi May 15, 2019 16:20
@coveralls
Copy link

coveralls commented May 15, 2019

Pull Request Test Coverage Report for Build 1347

  • 1 of 38 (2.63%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+8.3%) to 36.928%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sample/src/main/java/io/ona/kujaku/sample/activities/CaseRelationshipActivity.java 0 37 0.0%
Files with Coverage Reduction New Missed Lines %
sample/src/main/java/io/ona/kujaku/sample/activities/CaseRelationshipActivity.java 1 0.0%
Totals Coverage Status
Change from base Build 1343: 8.3%
Covered Lines: 2161
Relevant Lines: 5852

💛 - Coveralls

Copy link
Contributor

@githengi githengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am getting NPE on
sampleCasesSource.setGeoJson(boundaryFeatureCollection2);
Stack trace
java.lang.NullPointerException: Attempt to invoke virtual method 'void com.mapbox.mapboxsdk.style.sources.GeoJsonSource.setGeoJson(com.mapbox.geojson.FeatureCollection)' on a null object reference
at io.ona.kujaku.sample.activities.CaseRelationshipActivity$3.onClick(CaseRelationshipActivity.java:130)

@ekigamba ekigamba merged commit d124cae into master May 16, 2019
@ekigamba ekigamba deleted the issue/289-filter-cases-map branch May 16, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

G3.8 Filter cases on the map
3 participants