Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Toggle of my location #300

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Allow Toggle of my location #300

merged 4 commits into from
Jun 11, 2019

Conversation

githengi
Copy link
Contributor

@githengi githengi commented Jun 7, 2019

Resolves #299

@githengi githengi requested a review from ekigamba June 7, 2019 14:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1409

  • 5 of 15 (33.33%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 48.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
library/src/main/java/io/ona/kujaku/activities/MapActivity.java 0 1 0.0%
library/src/main/java/io/ona/kujaku/views/KujakuMapView.java 5 14 35.71%
Files with Coverage Reduction New Missed Lines %
library/src/main/java/io/ona/kujaku/activities/MapActivity.java 1 0.28%
library/src/main/java/io/ona/kujaku/views/KujakuMapView.java 1 26.8%
Totals Coverage Status
Change from base Build 1401: 0.4%
Covered Lines: 2351
Relevant Lines: 4817
💛 - Coveralls

@githengi githengi merged commit 78b9e16 into master Jun 11, 2019
@githengi githengi deleted the 299-toggle-my-location branch June 11, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekigamba ekigamba ekigamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Toggling on My Location button
3 participants
@githengi @coveralls @ekigamba