Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split polygon #307

Closed
wants to merge 40 commits into from
Closed

Split polygon #307

wants to merge 40 commits into from

Conversation

eotin
Copy link
Contributor

@eotin eotin commented Jul 10, 2019

No description provided.

eotin added 30 commits June 25, 2019 13:19
@eotin
Add Drawing activity with
ea048c9 
- Add MapBox annotations plugins
- Drawing Manager encapsulating the Circle/Line/Fill Manager
- Smart listeners
@eotin
Refactoring drawing feature
79db6c1
@eotin
Refactor Drawing Manager
e0d8af3 
Refactor KujakuLayer
TODO :
- Include KujakuLayer OnClick & OnLongClick in the drawing Manager
- Add Unit tests
@eotin
Refactor Click listeners
6f53f6b
@eotin
Create DrawingManagerIsNullException class
79ca54c 
Refactor DrawingManager and KujakuMapview to encapsulate APIs
@eotin
Refactor Drawing Manager
9547be5 
Update the Manifest.xml
@eotin
Add FillBoundaryLayerTest class
6586829
@eotin
Refactor ang begin unit tests
192d66c
@eotin
Fix Merge from onaio master
215d363
@eotin
Fix Codacy Review
127b203
@eotin
Fix Codacy Review
163ac85 
Fix build sample app
@eotin
Update android SDK version in travis.yml
52da0b0
@eotin
Create DrawingManagerTest class
11c617b 
Create ShadowCircleLayer class
@eotin
Add Drawing manager unit tests
53b0b53
@eotin
Improve Test coverage
1d9e879
@eotin
Remove unused import
5c0bb97
@eotin
Fix issue when running test with relinker version 1.3.1
965e03b
@eotin
Isolate Wtms functions from KujakuMapView class
b7781af
@eotin
Isolate Wtms functions from KujakuMapView class
13e3ec2
@eotin
Isolate Wtms functions from KujakuMapView class
3f205bd 
Isolate KujakuLayer private function from KujakuMapView class
@eotin
Isolate Permissions check from KujakuMapView class
4c9fb12
@eotin
Revert refactoring as the test 'enableAddPointShouldHideMarkerLayoutW…
1b55eb4 
…henPassedFalse' fails now (not locally)
@eotin
Refactor Drawing Manager to not add too much APIs in the kujakuMapVie…
ff78e86 
…w class
@eotin
Fixing codacy checks
7f68839
@eotin
Remove DrawingManagerIsNullException exception class
27c039c
@eotin
Feature Split Polygon
4633c10
@eotin
Add @nonnull and @nullable annotations
7febe2c
@eotin
Add Cancel Button
e2851dc 
Add SplittingManagerOptions for the SplittingManager
@eotin
Apply @ephraim changes.diff file
6f4438a
@eotin
Update Splitting Manager Options and use it into the Splitting Manager
7b5dfee
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1452

  • 177 of 213 (83.1%) changed or added relevant lines in 9 files are covered.
  • 268 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+4.6%) to 45.08%
Changes Missing Coverage Covered Lines Changed/Added Lines %
library/src/main/java/io/ona/kujaku/layers/BoundaryLayer.java 3 4 75.0%
library/src/main/java/io/ona/kujaku/plugin/switcher/layer/BaseLayer.java 0 1 0.0%
library/src/main/java/io/ona/kujaku/layers/ArrowLineLayer.java 0 3 0.0%
library/src/main/java/io/ona/kujaku/views/KujakuMapView.java 0 3 0.0%
library/src/main/java/io/ona/kujaku/manager/AnnotationRepositoryManager.java 9 14 64.29%
library/src/main/java/io/ona/kujaku/manager/SplittingManager.java 145 168 86.31%
Files with Coverage Reduction New Missed Lines %
utils/src/main/java/io/ona/kujaku/utils/exceptions/InvalidMapBoxStyleException.java 2 0.0%
utils/src/main/java/io/ona/kujaku/utils/config/DataSourceConfig.java 20 0.0%
utils/src/main/java/io/ona/kujaku/utils/config/InfoWindowConfig.java 26 0.0%
utils/src/main/java/io/ona/kujaku/utils/helpers/converters/GeoJSONFeature.java 35 12.77%
utils/src/main/java/io/ona/kujaku/utils/helpers/converters/GeoJSONHelper.java 41 0.0%
utils/src/main/java/io/ona/kujaku/utils/config/SortFieldConfig.java 42 0.0%
utils/src/main/java/io/ona/kujaku/utils/helpers/MapBoxStyleHelper.java 45 0.0%
utils/src/main/java/io/ona/kujaku/utils/config/KujakuConfig.java 57 0.0%
Totals Coverage Status
Change from base Build 1451: 4.6%
Covered Lines: 2410
Relevant Lines: 5346
💛 - Coveralls

@eotin eotin closed this Jul 10, 2019
@eotin eotin deleted the split-polygon branch July 16, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eotin @coveralls @ephraim