Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mapbox to 8.3.3 #319

Merged
merged 12 commits into from
Sep 26, 2019
Merged

Upgrade mapbox to 8.3.3 #319

merged 12 commits into from
Sep 26, 2019

Conversation

githengi
Copy link
Contributor

Resolves #318

@coveralls
Copy link

coveralls commented Sep 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1518

  • 3 of 12 (25.0%) changed or added relevant lines in 4 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+9.5%) to 52.554%
Changes Missing Coverage Covered Lines Changed/Added Lines %
library/src/main/java/io/ona/kujaku/views/KujakuMapView.java 0 2 0.0%
library/src/main/java/io/ona/kujaku/downloaders/MapBoxOfflineResourcesDownloader.java 0 3 0.0%
library/src/main/java/io/ona/kujaku/services/MapboxOfflineDownloaderService.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
library/src/main/java/io/ona/kujaku/services/MapboxOfflineDownloaderService.java 2 56.15%
library/src/main/java/io/ona/kujaku/utils/LogUtil.java 10 0.0%
Totals Coverage Status
Change from base Build 1505: 9.5%
Covered Lines: 2860
Relevant Lines: 5442
💛 - Coveralls

ekigamba
ekigamba suggested changes Sep 26, 2019
View reviewed changes
library/src/main/java/io/ona/kujaku/downloaders/MapBoxOfflineResourcesDownloader.java Outdated
* @param tileDownloadLimit maximum number of Mapbox-hosted tiles that may be downloaded
*/
public MapBoxOfflineResourcesDownloader withTileDownloadLimit(long tileDownloadLimit) {
if(offlineManager!=null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting of code (spacing around the if condition)

@githengi githengi merged commit 0ed1bea into master Sep 26, 2019
@githengi githengi deleted the 318-upgrade-mapbox-to-8.3.3 branch September 26, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekigamba ekigamba ekigamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Mapbox to 8.3.3
3 participants
@githengi @coveralls @ekigamba