Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase tries when retrieving profile #280

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Increase tries when retrieving profile #280

merged 3 commits into from
Apr 8, 2020

Conversation

FrankApiyo
Copy link
Member

@FrankApiyo FrankApiyo commented Apr 8, 2020 •
edited
Loading

Fixes: #281

@FrankApiyo
Make request to the user endpoint with :post
280e4be 
This should be done instead of :get. Using :post
causes the request to hit the master database instead
of the replica on api. This removes problems resulting
from synchronization with the replica.
@FrankApiyo
Increment max-entries to 4
09062cd
@FrankApiyo
Update tests
9072736
@ivermac ivermac changed the title Tackle some master slave database sync issues Increase tries when retrieving profile Apr 8, 2020
@FrankApiyo FrankApiyo requested a review from ivermac April 8, 2020 10:14
ivermac
ivermac approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@FrankApiyo FrankApiyo merged commit ae740d4 into master Apr 8, 2020
@FrankApiyo FrankApiyo deleted the tackle-some-master-slave-database-sync-issues branch April 8, 2020 10:56
@RayceeM RayceeM mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivermac ivermac ivermac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deal with some issues resulting from a master-replica database set up
2 participants
@FrankApiyo @ivermac