Add new param for getting chat data #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciremusyoka
commented
Feb 2, 2022
| (parse-http :get url) => :some-chart))) | ||
| (parse-http :get url) => :some-chart)) | ||
|
|
||
| (facts "About get chart data" |
There was a problem hiding this comment.
The get function was not tested. Added tests for all the three possible scenarios
There was a problem hiding this comment.
small change that might be needed though: the assertions should be inside the fact statements
There was a problem hiding this comment.
For example (from the documentation here)
(fact "one plus one is two" (+ 1 1) => 2)
FrankApiyo
reviewed
Feb 2, 2022
src/milia/api/charts.cljc
Outdated
Comment on lines
43
to
45
| url (if field-xpath | ||
| (make-url (format url-template id field-xpath group-by)) | ||
| (make-url (format url-template id field-name group-by)))] |
There was a problem hiding this comment.
Suggested change
| url (if field-xpath | |
| (make-url (format url-template id field-xpath group-by)) | |
| (make-url (format url-template id field-name group-by)))] | |
| url (make-url (format url-template id (or field-xpath field-name) group-by))] |
ciremusyoka
force-pushed
the
update-chart-data-get
branch
from
b68f4f2
to
0c2243a
Compare
FrankApiyo
approved these changes
Feb 2, 2022
KipSigei
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/onaio/zebra/issues/6675
Add an option of using field_xpath param to get single chart data.